Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13653 )
Change subject: IMPALA-8599: Create a Maven module for query event hook API ...................................................................... Patch Set 2: Code-Review+1 (1 comment) I'm not a mvn ninja, so I prefer an additional set of eyes on the pom contents. http://gerrit.cloudera.org:8080/#/c/13653/2/query-event-hook-api/CMakeLists.txt File query-event-hook-api/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/13653/2/query-event-hook-api/CMakeLists.txt@18 PS2, Line 18: DEPENDS gen-deps impala-parent qq: why is this needed? Looking at the hook, seems like a standalone thing. -- To view, visit http://gerrit.cloudera.org:8080/13653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84c422d83c19b75c3d1d7a772b971f4f7704d44c Gerrit-Change-Number: 13653 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 14 Jun 2019 21:57:55 +0000 Gerrit-HasComments: Yes
