Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 )
Change subject: [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement ...................................................................... Patch Set 2: (1 comment) I'm going to go ahead and post the version that sidesteps the catalog. http://gerrit.cloudera.org:8080/#/c/13545/2/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/13545/2/be/src/scheduling/scheduler.cc@801 PS2, Line 801: uint32_t hash = HashUtil::Hash(&hdfs_file_split->full_path_hash, : sizeof(hdfs_file_split->full_path_hash), 0); > why hash the hash instead of just making the hash here be a uint32_t direct Fixed this. Java hashCode() returns a signed integer and backend uses unsigned. I was punting on deciding the right place to cast. -- To view, visit http://gerrit.cloudera.org:8080/13545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46c739fc31af539af2b3509e2a161f4e29f44d7b Gerrit-Change-Number: 13545 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Sat, 15 Jun 2019 00:42:11 +0000 Gerrit-HasComments: Yes
