Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13663 )
Change subject: IMPALA-8671: Do not re-create RangerAuthorizationChecker instance on catalog update ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/13663/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationFactory.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationFactory.java: http://gerrit.cloudera.org:8080/#/c/13663/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationFactory.java@79 PS3, Line 79: // since RangerAuthorizationChecker is stateless and creating a new instance of > do we need to reinit the ranger plugin for explicit REFRESH AUTHORIZATION c No, we can use the existing plugin instance and call a refreshTagsAndPolicy API instead of re-initing. http://gerrit.cloudera.org:8080/#/c/13663/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationFactory.java@81 PS3, Line 81: // Ranger plugin. > this isn't safe under concurrency unless authzChecker is volatile. Should w Good idea. Done. -- To view, visit http://gerrit.cloudera.org:8080/13663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabd5c1b5c7cafc7a03681def0c0f6f775d690c41 Gerrit-Change-Number: 13663 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 17 Jun 2019 20:22:56 +0000 Gerrit-HasComments: Yes
