Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12884 )

Change subject: IMPALA-7290: part 2: Add HS2 support to Impala shell
......................................................................


Patch Set 24:

(1 comment)

I chickened out on changing the default to HS2 - I think the chance of breaking 
workflows is non-zero, even though the change is mostly transparent so we 
should hold off on flipping the default until a breaking version. Let me know 
if this makes sense to you.

http://gerrit.cloudera.org:8080/#/c/12884/22/shell/impala_shell.py
File shell/impala_shell.py:

http://gerrit.cloudera.org:8080/#/c/12884/22/shell/impala_shell.py@1178
PS22, Line 1178:       self.close_connection()
> ?
Done



--
To view, visit http://gerrit.cloudera.org:8080/12884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d5cc83d545aacc659523f29b1d6feed672e2a12
Gerrit-Change-Number: 12884
Gerrit-PatchSet: 24
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Fredy Wijaya <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Thomas Marshall <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Tue, 18 Jun 2019 16:12:57 +0000
Gerrit-HasComments: Yes

Reply via email to