Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13664 )
Change subject: WIP: IMPALA-7434. Handle invalidation races in CatalogdMetaProvider ...................................................................... Patch Set 1: > Patch Set 1: > > I'm trying to understand the issue here. Apart from the versioning problem, > is the thread-safety issue in loadWithCaching() described in > https://softwaremill.com/race-condition-cache-guava-caffeine/ not a problem > here? That's exactly the problem this is fixing. It ensures that an invalidate concurrent with loadWithCaching() will cause the concurrent load to _not_ write its result to the cache. In terms of multiple threads calling loadWithCaching() at the same time, I think our code appropriately ensures that the first thread who gets there inserts a Future, and the second thread piggy-backs onto that same future. -- To view, visit http://gerrit.cloudera.org:8080/13664 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70f377db88e204825a909389f28dc3451815235c Gerrit-Change-Number: 13664 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 18 Jun 2019 17:04:28 +0000 Gerrit-HasComments: No
