Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13664 )
Change subject: IMPALA-7534. Handle invalidation races in CatalogdMetaProvider ...................................................................... Patch Set 4: Code-Review+1 (4 comments) lgtm http://gerrit.cloudera.org:8080/#/c/13664/4/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/13664/4/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@243 PS4, Line 243: AtomicInteger piggybackSuccessCountForTests = new AtomicInteger(); nit: final http://gerrit.cloudera.org:8080/#/c/13664/4/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@250 PS4, Line 250: AtomicInteger piggybackExceptionCountForTests = new AtomicInteger(); nit: final http://gerrit.cloudera.org:8080/#/c/13664/4/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@520 PS4, Line 520: " nit: Also log piggyBacked for completeness? http://gerrit.cloudera.org:8080/#/c/13664/4/fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java File fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java: http://gerrit.cloudera.org:8080/#/c/13664/4/fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java@289 PS4, Line 289: if (testSuccessCase) throw e; Should we also assert that in either case, the future is removed from the cache ? (and replaced by something meaningful in the success case) -- To view, visit http://gerrit.cloudera.org:8080/13664 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70f377db88e204825a909389f28dc3451815235c Gerrit-Change-Number: 13664 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Wed, 19 Jun 2019 00:49:58 +0000 Gerrit-HasComments: Yes
