Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13698 )
Change subject: IMPALA-7947: script to push images to docker repo ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13698/2/docker/push-images.sh File docker/push-images.sh: http://gerrit.cloudera.org:8080/#/c/13698/2/docker/push-images.sh@26 PS2, Line 26: Images can be prefixed with an optional prefix. > Nit: The prefix is required. Done http://gerrit.cloudera.org:8080/#/c/13698/2/docker/push-images.sh@37 PS2, Line 37: someuser/experimental > Nit: Do callers need to always include the username? If so, it might make s Not necessarily. There are non-prefixed images on docker hub. And you don't want to include a user prefix if pushing to a different docker repository. The prefix mechanism is more general in that it is just based on string concatenation rather than trying to anticipate too much about how the path or name might be structured. I figure there are probably some use cases this doesn't support that well, but we can tweak the script if needed. -- To view, visit http://gerrit.cloudera.org:8080/13698 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0996b090f513351b58c801ed7149f80c4188f903 Gerrit-Change-Number: 13698 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 21 Jun 2019 17:47:11 +0000 Gerrit-HasComments: Yes
