Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/13648 )
Change subject: IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/13648/4/be/src/benchmarks/date-benchmark.cc File be/src/benchmarks/date-benchmark.cc: http://gerrit.cloudera.org:8080/#/c/13648/4/be/src/benchmarks/date-benchmark.cc@56 PS4, Line 56: double rd = static_cast<double>(rand()) / RAND_MAX * range_size; > I think that using the uniform distribution provided by <random> would make Done, the results are pretty much the same. -- To view, visit http://gerrit.cloudera.org:8080/13648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If404bffdaf055c769e79ffa8f193bac415cfdd1a Gerrit-Change-Number: 13648 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 24 Jun 2019 08:56:28 +0000 Gerrit-HasComments: Yes
