Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/13508 )
Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/13508/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13508/1//COMMIT_MSG@7 PS1, Line 7: NPE > nit: might worth spell it out at least once. Done http://gerrit.cloudera.org:8080/#/c/13508/1/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java File fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java: http://gerrit.cloudera.org:8080/#/c/13508/1/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@124 PS1, Line 124: // in a bad state, eg. deleted externally from Kudu, can be dropped. > Should we log the exception? Done http://gerrit.cloudera.org:8080/#/c/13508/1/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@124 PS1, Line 124: // in a bad state, eg. deleted externally from Kudu, can be dropped. > We should have an E2E test here by having a table that is dropped externall I have tried this but apparently that won't work. I created a table with Impala, dropped it with Hive and tried to drop it with Impala. The TableLoadingException case was covered, that is fine, but later on in CatalogOpExecutor.dropTableOrView() an ImpalaRuntimeException is thrown saying the table no longer exists in HSM and should run invalidate metadata. All in all the updateOwnerPrivileges() function is not invoked. -- To view, visit http://gerrit.cloudera.org:8080/13508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952 Gerrit-Change-Number: 13508 Gerrit-PatchSet: 3 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 26 Jun 2019 13:25:14 +0000 Gerrit-HasComments: Yes
