Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13746 )

Change subject: IMPALA-8717: impala-shell support for HS2 HTTP endpoint
......................................................................


Patch Set 3:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/13746/3/shell/impala_client.py
File shell/impala_client.py:

http://gerrit.cloudera.org:8080/#/c/13746/3/shell/impala_client.py@375
PS3, Line 375:
flake8: E261 at least two spaces before inline comment


http://gerrit.cloudera.org:8080/#/c/13746/3/shell/impala_client.py@379
PS3, Line 379:
flake8: E222 multiple spaces after operator


http://gerrit.cloudera.org:8080/#/c/13746/3/shell/impala_client.py@384
PS3, Line 384:
flake8: E203 whitespace before ':'


http://gerrit.cloudera.org:8080/#/c/13746/3/shell/impala_shell.py
File shell/impala_shell.py:

http://gerrit.cloudera.org:8080/#/c/13746/3/shell/impala_shell.py@537
PS3, Line 537: .
flake8: E501 line too long (93 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13746/3/shell/impala_shell.py@797
PS3, Line 797: L
flake8: E501 line too long (102 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13746/3/shell/option_parser.py
File shell/option_parser.py:

http://gerrit.cloudera.org:8080/#/c/13746/3/shell/option_parser.py@266
PS3, Line 266: "
flake8: E501 line too long (91 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13746/3/tests/common/test_dimensions.py
File tests/common/test_dimensions.py:

http://gerrit.cloudera.org:8080/#/c/13746/3/tests/common/test_dimensions.py@120
PS3, Line 120: def create_http_transport_dimension():
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/13746/3/tests/common/test_dimensions.py@123
PS3, Line 123: def beeswax_http_constraint(v):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/13746/3/tests/shell/util.py
File tests/shell/util.py:

http://gerrit.cloudera.org:8080/#/c/13746/3/tests/shell/util.py@153
PS3, Line 153: )
flake8: E501 line too long (93 > 90 characters)



--
To view, visit http://gerrit.cloudera.org:8080/13746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8323950857dfe1c1dfd5377fde79f87bc2ce9534
Gerrit-Change-Number: 13746
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Thu, 27 Jun 2019 06:18:41 +0000
Gerrit-HasComments: Yes

Reply via email to