Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13633 )
Change subject: IMPALA-8585: Insert data into ACID table during dataload ...................................................................... Patch Set 3: (2 comments) Please ignore patch set 2, it ignored some additional stuff by mistake. http://gerrit.cloudera.org:8080/#/c/13633/1/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/13633/1/testdata/datasets/functional/functional_schema_template.sql@2137 PS1, Line 2137: -- Compactions could be also interesting, but seem to be sporadically very slow. > mind filing this JIRA and adding a TODO here? then we can commit this with Done http://gerrit.cloudera.org:8080/#/c/13633/2/tests/query_test/test_acid.py File tests/query_test/test_acid.py: http://gerrit.cloudera.org:8080/#/c/13633/2/tests/query_test/test_acid.py@55 PS2, Line 55: # Tests that should run for all (HDFS based) table formats, not just text. > flake8: E302 expected 2 blank lines, found 1 Done -- To view, visit http://gerrit.cloudera.org:8080/13633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id459519d5b963ea760c44719c12736bf104938f9 Gerrit-Change-Number: 13633 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 27 Jun 2019 17:24:09 +0000 Gerrit-HasComments: Yes
