Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13550 )
Change subject: WIP IMPALA-8484: Run queries on disjoint executor groups ...................................................................... Patch Set 7: (21 comments) PS8 is to please pyflake and clang-tidy http://gerrit.cloudera.org:8080/#/c/13550/7/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/13550/7/bin/start-impala-cluster.py@274 PS7, Line 274: > flake8: E251 unexpected spaces around keyword / parameter equals Done http://gerrit.cloudera.org:8080/#/c/13550/7/bin/start-impala-cluster.py@274 PS7, Line 274: > flake8: E251 unexpected spaces around keyword / parameter equals Done http://gerrit.cloudera.org:8080/#/c/13550/7/bin/start-impala-cluster.py@439 PS7, Line 439: > flake8: E251 unexpected spaces around keyword / parameter equals Done http://gerrit.cloudera.org:8080/#/c/13550/7/bin/start-impala-cluster.py@439 PS7, Line 439: > flake8: E251 unexpected spaces around keyword / parameter equals Done http://gerrit.cloudera.org:8080/#/c/13550/7/bin/start-impala-cluster.py@453 PS7, Line 453: > flake8: E251 unexpected spaces around keyword / parameter equals Done http://gerrit.cloudera.org:8080/#/c/13550/7/bin/start-impala-cluster.py@453 PS7, Line 453: > flake8: E251 unexpected spaces around keyword / parameter equals Done http://gerrit.cloudera.org:8080/#/c/13550/7/bin/start-impala-cluster.py@713 PS7, Line 713: ; > flake8: E703 statement ends with a semicolon Done http://gerrit.cloudera.org:8080/#/c/13550/7/tests/custom_cluster/test_auto_scaling.py File tests/custom_cluster/test_auto_scaling.py: http://gerrit.cloudera.org:8080/#/c/13550/7/tests/custom_cluster/test_auto_scaling.py@21 PS7, Line 21: import json > flake8: F401 'json' imported but unused Done http://gerrit.cloudera.org:8080/#/c/13550/7/tests/custom_cluster/test_auto_scaling.py@22 PS7, Line 22: import requests > flake8: F401 'requests' imported but unused Done http://gerrit.cloudera.org:8080/#/c/13550/7/tests/custom_cluster/test_auto_scaling.py@31 PS7, Line 31: class TestAutoScaling(CustomClusterTestSuite): > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/13550/7/tests/custom_cluster/test_auto_scaling.py@62 PS7, Line 62: 3 > flake8: E225 missing whitespace around operator Done http://gerrit.cloudera.org:8080/#/c/13550/7/tests/util/auto_scaler.py File tests/util/auto_scaler.py: http://gerrit.cloudera.org:8080/#/c/13550/7/tests/util/auto_scaler.py@31 PS7, Line 31: class AutoScaler(object): > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/13550/7/tests/util/auto_scaler.py@181 PS7, Line 181: = > flake8: E711 comparison to None should be 'if cond is None:' Done http://gerrit.cloudera.org:8080/#/c/13550/7/tests/util/auto_scaler.py@293 PS7, Line 293: if __name__ == "__main__": > flake8: E305 expected 2 blank lines after class or function definition, fou Done http://gerrit.cloudera.org:8080/#/c/13550/7/tests/util/concurrent_workload.py File tests/util/concurrent_workload.py: http://gerrit.cloudera.org:8080/#/c/13550/7/tests/util/concurrent_workload.py@24 PS7, Line 24: import signal > flake8: F401 'signal' imported but unused Done http://gerrit.cloudera.org:8080/#/c/13550/7/tests/util/concurrent_workload.py@27 PS7, Line 27: import _strptime > flake8: F401 '_strptime' imported but unused Done http://gerrit.cloudera.org:8080/#/c/13550/7/tests/util/concurrent_workload.py@35 PS7, Line 35: class ConcurrentWorkload(object): > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/13550/7/tests/util/concurrent_workload.py@68 PS7, Line 68: e > flake8: F841 local variable 'e' is assigned to but never used Done http://gerrit.cloudera.org:8080/#/c/13550/7/tests/util/concurrent_workload.py@109 PS7, Line 109: > flake8: E201 whitespace after '[' Done http://gerrit.cloudera.org:8080/#/c/13550/7/tests/util/concurrent_workload.py@118 PS7, Line 118: = > flake8: E711 comparison to None should be 'if cond is None:' Done http://gerrit.cloudera.org:8080/#/c/13550/7/tests/util/concurrent_workload.py@149 PS7, Line 149: if __name__ == "__main__": > flake8: E305 expected 2 blank lines after class or function definition, fou Done -- To view, visit http://gerrit.cloudera.org:8080/13550 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a1d0900f2a82bd2fc0a906cc094e442cffa189b Gerrit-Change-Number: 13550 Gerrit-PatchSet: 7 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 27 Jun 2019 23:13:55 +0000 Gerrit-HasComments: Yes
