Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13736 )
Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13736/2/testdata/workloads/functional-query/queries/QueryTest/acid-profile.test File testdata/workloads/functional-query/queries/QueryTest/acid-profile.test: http://gerrit.cloudera.org:8080/#/c/13736/2/testdata/workloads/functional-query/queries/QueryTest/acid-profile.test@16 PS2, Line 16: # Verify that ValidWriteIdLists in the profile > nit: missing "is" I will change http://gerrit.cloudera.org:8080/#/c/13736/2/tests/query_test/test_acid.py File tests/query_test/test_acid.py: http://gerrit.cloudera.org:8080/#/c/13736/2/tests/query_test/test_acid.py@55 PS2, Line 55: @SkipIfCatalogV2.hms_event_polling_enabled() > Can you explain why this is needed? Other acid tests also use the "create i When local catalogV2 combines with hms_enent_polling enabled, it seems catalog loading the table by itself, the query statement cannot trigger loading the table(not sure it is by design or a bug). Because of the WriteIdlist profile is part of table loading, it can not be shown. This skip to avoid flaky tests. -- To view, visit http://gerrit.cloudera.org:8080/13736 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905 Gerrit-Change-Number: 13736 Gerrit-PatchSet: 2 Gerrit-Owner: Yongzhi Chen <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yongzhi Chen <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 28 Jun 2019 19:59:40 +0000 Gerrit-HasComments: Yes
