Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13740 )
Change subject: [WIP] IMPALA-7486: Prototype for admitting less mem on coord ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/13740/2/be/src/scheduling/query-schedule.cc File be/src/scheduling/query-schedule.cc: http://gerrit.cloudera.org:8080/#/c/13740/2/be/src/scheduling/query-schedule.cc@55 PS2, Line 55: const TQueryOptions& query_options, RuntimeProfile* summary_profile, bool is_dedicated_coord) line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/13740/2/be/src/scheduling/query-schedule.cc@266 PS2, Line 266: coord_backend_mem_to_admit_ = is_dedicated_coord() ? GetDedicatedCoordMemoryEstimate() : line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/13740/2/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: http://gerrit.cloudera.org:8080/#/c/13740/2/fe/src/main/java/org/apache/impala/planner/Planner.java@418 PS2, Line 418: // fragment instances, so keep aside all the untracked memory that might be required. line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/13740/2/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/13740/2/tests/custom_cluster/test_admission_controller.py@563 PS2, Line 563: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/13740/2/tests/custom_cluster/test_admission_controller.py@578 PS2, Line 578: flake8: E203 whitespace before ':' -- To view, visit http://gerrit.cloudera.org:8080/13740 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b94e7293b91dec8a18491079c34923eadd94b21 Gerrit-Change-Number: 13740 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 28 Jun 2019 22:55:05 +0000 Gerrit-HasComments: Yes
