radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 )
Change subject: IMPALA-8572: improve QueryEventHook execution ...................................................................... Patch Set 7: (2 comments) add comment where you should probably start reviewing http://gerrit.cloudera.org:8080/#/c/13748/7/fe/src/main/java/org/apache/impala/hooks/FixedCapacityQueryHookExecutor.java File fe/src/main/java/org/apache/impala/hooks/FixedCapacityQueryHookExecutor.java: http://gerrit.cloudera.org:8080/#/c/13748/7/fe/src/main/java/org/apache/impala/hooks/FixedCapacityQueryHookExecutor.java@161 PS7, Line 161: Future<QueryEventHook> submitOnQueryComplete( Entry point for executing hook onQueryComplete asynchronously http://gerrit.cloudera.org:8080/#/c/13748/7/fe/src/main/java/org/apache/impala/hooks/QueryEventHookManager.java File fe/src/main/java/org/apache/impala/hooks/QueryEventHookManager.java: http://gerrit.cloudera.org:8080/#/c/13748/7/fe/src/main/java/org/apache/impala/hooks/QueryEventHookManager.java@133 PS7, Line 133: final String msg = String.format("hook timeout should be positive but was {}. " + might allow negative value to signify block indefinitely -- To view, visit http://gerrit.cloudera.org:8080/13748 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb88422f7cfe86947d11ce57d2b4c63e57d1b643 Gerrit-Change-Number: 13748 Gerrit-PatchSet: 7 Gerrit-Owner: radford nguyen <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: radford nguyen <[email protected]> Gerrit-Comment-Date: Tue, 02 Jul 2019 01:12:20 +0000 Gerrit-HasComments: Yes
