Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13775 )

Change subject: build: use thin static archives
......................................................................


Patch Set 1:

> Patch Set 1:
>
> I tried this out and I couldn't tell a difference when doing buildall.sh 
> -skiptests. Can you include a measurement of what got faster?

hmm, it should make the generated .a files much smaller and thus link faster. 
Let me run some tests, maybe I put this in the wrong spot in the CMakeLists.txt 
file (I copied it from Kudu where we saw a speedup but will admit I didn't 
verify it in Impala)


--
To view, visit http://gerrit.cloudera.org:8080/13775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b54b5be8658c951914758c406cca55d4cc1756e
Gerrit-Change-Number: 13775
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Tue, 02 Jul 2019 19:17:45 +0000
Gerrit-HasComments: No

Reply via email to