Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13777 )
Change subject: IMPALA-8519: [DOCS] Doc the limitation in insert events from SparkSQL ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/13777/5/docs/topics/impala_metadata.xml File docs/topics/impala_metadata.xml: http://gerrit.cloudera.org:8080/#/c/13777/5/docs/topics/impala_metadata.xml@137 PS5, Line 137: table In this case, it actually refreshes the partition not the table http://gerrit.cloudera.org:8080/#/c/13777/5/docs/topics/impala_metadata.xml@216 PS5, Line 216: operation Using APIs instead of operation is better in my opinion. http://gerrit.cloudera.org:8080/#/c/13777/5/docs/topics/impala_metadata.xml@218 PS5, Line 218: /tmp/spark_unpart I think it would be easier to understand if the example provides a realistic table location like /user/hive/warehouse/spark_etl.db/customers/date=01012019 http://gerrit.cloudera.org:8080/#/c/13777/5/docs/topics/impala_metadata.xml@258 PS5, Line 258: hive.metastore.dml.events We should modify this text to say that this configuration should also be set to true in the hive-site.xml used by the spark applications (typically /etc/hive/conf/hive-site.xml) so that INSERT events are generated when the spark application inserts data into existing tables and partitions. -- To view, visit http://gerrit.cloudera.org:8080/13777 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36cfc7e592ed2588a8c1f8375033d60492b27a4f Gerrit-Change-Number: 13777 Gerrit-PatchSet: 5 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Wed, 03 Jul 2019 17:36:39 +0000 Gerrit-HasComments: Yes
