Impala Public Jenkins has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/13737 )
Change subject: IMPALA-8710: Increase allowed bit width to 64 for bit packing
......................................................................
IMPALA-8710: Increase allowed bit width to 64 for bit packing
Increasing the allowed bit width for bit packing and bit unpacking to 64
bits. This will be needed to support the Parquet delta encoding.
Added new methods to BitWriter and BatchedBitReader handling Uleb and
ZigZag integers for 64 bits, also needed by delta encoding.
The performance of bit unpacking is either the same or better with the
new implementation, depending on bit width.
Testing:
- Modified bit packing and unpacking tests to test bit widths up to 64
bits.
- Tests covering the additions in BitWriter and BatchedBitReader.
Change-Id: I3ff3b387cbe8e41dd78c454777711ef54de4afa8
Reviewed-on: http://gerrit.cloudera.org:8080/13737
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
---
M be/src/benchmarks/bit-packing-benchmark.cc
M be/src/util/CMakeLists.txt
M be/src/util/bit-packing-test.cc
M be/src/util/bit-packing.h
M be/src/util/bit-packing.inline.h
M be/src/util/bit-stream-utils-test.cc
M be/src/util/bit-stream-utils.h
M be/src/util/bit-stream-utils.inline.h
M be/src/util/rle-encoding.h
M be/src/util/rle-test.cc
10 files changed, 414 insertions(+), 204 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ff3b387cbe8e41dd78c454777711ef54de4afa8
Gerrit-Change-Number: 13737
Gerrit-PatchSet: 9
Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
