Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13807 )
Change subject: IMPALA-8741: Speed up bit unpacking by vectorisation ...................................................................... Patch Set 3: (186 comments) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/bit-packing-test.cc File be/src/util/bit-packing-test.cc: http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/bit-packing-test.cc@110 PS3, Line 110: EXPECT_EQ(in[i] & mask, out[i]) << "Didn't get back input value " << i << ". Bit width: " << bit_width << "."; line too long (116 > 90) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/bit-packing.inline.h File be/src/util/bit-packing.inline.h: http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/bit-packing.inline.h@91 PS3, Line 91: in_pos = UnpackInBatchesOf32Vectorized<OutType, BIT_WIDTH>(batches_to_read, in_pos, out_pos); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/bit-packing.inline.h@93 PS3, Line 93: in_pos = UnpackInBatchesOf32<OutType, BIT_WIDTH>(batches_to_read, in_pos, in_bytes, out_pos); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py File be/src/util/vectorised_bit_unpacking_generator.py: http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@25 PS3, Line 25: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@33 PS3, Line 33: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@35 PS3, Line 35: @unique flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@44 PS3, Line 44: @unique flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@74 PS3, Line 74: class UnpackParams: flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@90 PS3, Line 90: e flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@94 PS3, Line 94: o flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@129 PS3, Line 129: class GeneratedCode: flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@138 PS3, Line 138: a flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@139 PS3, Line 139: c flake8: E501 line too long (99 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@140 PS3, Line 140: u flake8: E501 line too long (97 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@150 PS3, Line 150: ) flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@163 PS3, Line 163: h flake8: E501 line too long (99 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@172 PS3, Line 172: e flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@177 PS3, Line 177: class UnpackMethod(metaclass=ABCMeta): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@177 PS3, Line 177: = flake8: E999 SyntaxError: invalid syntax http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@186 PS3, Line 186: o flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@194 PS3, Line 194: e flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@201 PS3, Line 201: t flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@202 PS3, Line 202: t flake8: E501 line too long (99 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@206 PS3, Line 206: class UnpackStage: flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@208 PS3, Line 208: o flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@220 PS3, Line 220: class BitScatter(UnpackMethod): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@238 PS3, Line 238: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@240 PS3, Line 240: s flake8: E501 line too long (94 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@261 PS3, Line 261: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@293 PS3, Line 293: _ flake8: E501 line too long (99 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@295 PS3, Line 295: l flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@296 PS3, Line 296: b flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@297 PS3, Line 297: b flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@298 PS3, Line 298: m flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@299 PS3, Line 299: d flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@300 PS3, Line 300: o flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@301 PS3, Line 301: n flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@305 PS3, Line 305: class MiniStage(metaclass=ABCMeta): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@307 PS3, Line 307: flake8: E501 line too long (99 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@314 PS3, Line 314: a flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@315 PS3, Line 315: r flake8: E501 line too long (97 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@319 PS3, Line 319: class MiniStagePipeline: flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@321 PS3, Line 321: g flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@332 PS3, Line 332: e flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@333 PS3, Line 333: s flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@336 PS3, Line 336: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@339 PS3, Line 339: flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@349 PS3, Line 349: class Broadcast(MiniStage): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@351 PS3, Line 351: flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@385 PS3, Line 385: d flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@386 PS3, Line 386: i flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@387 PS3, Line 387: i flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@389 PS3, Line 389: class Store(MiniStage): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@391 PS3, Line 391: t flake8: E501 line too long (97 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@405 PS3, Line 405: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@432 PS3, Line 432: class VectorShiftRight(MiniStage): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@434 PS3, Line 434: h flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@459 PS3, Line 459: s flake8: E126 continuation line over-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@489 PS3, Line 489: u flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@490 PS3, Line 490: s flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@491 PS3, Line 491: s flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@495 PS3, Line 495: class VectorAlignHighOn32Shift(MiniStage): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@497 PS3, Line 497: s flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@498 PS3, Line 498: t flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@499 PS3, Line 499: flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@500 PS3, Line 500: flake8: E501 line too long (97 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@525 PS3, Line 525: . flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@526 PS3, Line 526: o flake8: E126 continuation line over-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@549 PS3, Line 549: s flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@557 PS3, Line 557: t flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@566 PS3, Line 566: s flake8: E501 line too long (94 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@579 PS3, Line 579: s flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@580 PS3, Line 580: s flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@584 PS3, Line 584: class VectorBitwidthAnd(MiniStage): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@586 PS3, Line 586: flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@604 PS3, Line 604: o flake8: E126 continuation line over-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@631 PS3, Line 631: r flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@633 PS3, Line 633: u flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@634 PS3, Line 634: b flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@635 PS3, Line 635: m flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@639 PS3, Line 639: class VectorShuffle32to16(MiniStage): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@653 PS3, Line 653: a flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@692 PS3, Line 692: y flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@694 PS3, Line 694: s flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@695 PS3, Line 695: s flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@711 PS3, Line 711: class VectorShuffle32Deinterleave(MiniStage): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@713 PS3, Line 713: s flake8: E501 line too long (97 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@714 PS3, Line 714: r flake8: E501 line too long (94 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@723 PS3, Line 723: ; flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@746 PS3, Line 746: y flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@748 PS3, Line 748: s flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@749 PS3, Line 749: s flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@753 PS3, Line 753: class VectorShuffle32DeinterleavePack16(MiniStage): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@755 PS3, Line 755: d flake8: E501 line too long (97 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@772 PS3, Line 772: o flake8: E126 continuation line over-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@787 PS3, Line 787: 6 flake8: E501 line too long (110 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@806 PS3, Line 806: p flake8: E501 line too long (97 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@809 PS3, Line 809: y flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@811 PS3, Line 811: s flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@812 PS3, Line 812: s flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@826 PS3, Line 826: p flake8: E501 line too long (97 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@829 PS3, Line 829: y flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@831 PS3, Line 831: s flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@832 PS3, Line 832: s flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@839 PS3, Line 839: flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@871 PS3, Line 871: class Vectorization(UnpackMethod, metaclass=ABCMeta): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@894 PS3, Line 894: class Vectorization_16_bw_1_4(Vectorization): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@898 PS3, Line 898: 4 flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@899 PS3, Line 899: k flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@923 PS3, Line 923: class Vectorization_16_bw_5_8(Vectorization): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@927 PS3, Line 927: 8 flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@928 PS3, Line 928: k flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@951 PS3, Line 951: class Vectorization_32_bw_1_4(Vectorization): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@955 PS3, Line 955: 4 flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@956 PS3, Line 956: flake8: E501 line too long (99 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@957 PS3, Line 957: t flake8: E501 line too long (99 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@961 PS3, Line 961: v flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@962 PS3, Line 962: flake8: E501 line too long (94 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@963 PS3, Line 963: d flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@986 PS3, Line 986: class Vectorization_32_bw_5_8(Vectorization): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@990 PS3, Line 990: 8 flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@991 PS3, Line 991: , flake8: E501 line too long (97 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@992 PS3, Line 992: n flake8: E501 line too long (97 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@996 PS3, Line 996: v flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@997 PS3, Line 997: flake8: E501 line too long (99 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@998 PS3, Line 998: flake8: E501 line too long (99 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1001 PS3, Line 1001: u flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1002 PS3, Line 1002: n flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1003 PS3, Line 1003: , flake8: E501 line too long (99 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1004 PS3, Line 1004: f flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1028 PS3, Line 1028: class Vectorization_32_bw_9_16(Vectorization): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1032 PS3, Line 1032: 1 flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1033 PS3, Line 1033: , flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1034 PS3, Line 1034: t flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1035 PS3, Line 1035: flake8: E501 line too long (97 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1036 PS3, Line 1036: flake8: E501 line too long (99 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1037 PS3, Line 1037: i flake8: E501 line too long (99 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1038 PS3, Line 1038: n flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1042 PS3, Line 1042: v flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1043 PS3, Line 1043: flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1044 PS3, Line 1044: e flake8: E501 line too long (99 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1045 PS3, Line 1045: flake8: E501 line too long (99 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1046 PS3, Line 1046: a flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1047 PS3, Line 1047: r flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1071 PS3, Line 1071: class Vectorization_64_bw_1(Vectorization): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1075 PS3, Line 1075: e flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1076 PS3, Line 1076: g flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1078 PS3, Line 1078: flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1079 PS3, Line 1079: flake8: E501 line too long (97 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1102 PS3, Line 1102: class Vectorization_64_bw_2_16(Vectorization): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1106 PS3, Line 1106: _ flake8: E501 line too long (99 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1107 PS3, Line 1107: i flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1130 PS3, Line 1130: def calculate_unpack_method(output_size, bit_width): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1171 PS3, Line 1171: def calculate_start_byte_offset_and_used_bits(total_bits, read_bits, read_word_size): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1175 PS3, Line 1175: o flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1176 PS3, Line 1176: r flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1193 PS3, Line 1193: def calculate_load_size(total_bits, max_input_size): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1197 PS3, Line 1197: e flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1207 PS3, Line 1207: def generate_unpack_plan(output_size, bit_width, no_of_elements): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1211 PS3, Line 1211: t flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1212 PS3, Line 1212: l flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1228 PS3, Line 1228: t flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1249 PS3, Line 1249: def generate_code(unpack_plan): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1259 PS3, Line 1259: t flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1265 PS3, Line 1265: def generate_function(output_size, bit_width, no_of_elements, batches): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1269 PS3, Line 1269: u flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1271 PS3, Line 1271: flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1272 PS3, Line 1272: e flake8: E501 line too long (99 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1273 PS3, Line 1273: o flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1275 PS3, Line 1275: a flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1276 PS3, Line 1276: e flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1294 PS3, Line 1294: o flake8: E126 continuation line over-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1338 PS3, Line 1338: ( flake8: E501 line too long (97 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1339 PS3, Line 1339: g flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1340 PS3, Line 1340: g flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1341 PS3, Line 1341: g flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1386 PS3, Line 1386: , flake8: E501 line too long (108 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1403 PS3, Line 1403: def find_clang_format_executable(): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1431 PS3, Line 1431: def get_parser(): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1438 PS3, Line 1438: \ flake8: E251 unexpected spaces around keyword / parameter equals http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1438 PS3, Line 1438: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1444 PS3, Line 1444: e flake8: E501 line too long (94 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1448 PS3, Line 1448: def main(): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1459 PS3, Line 1459: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1459 PS3, Line 1459: impala_home = os.environ.get("IMPALA_HOME", None) line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/13807/3/be/src/util/vectorised_bit_unpacking_generator.py@1483 PS3, Line 1483: if __name__ == "__main__": flake8: E305 expected 2 blank lines after class or function definition, found 1 -- To view, visit http://gerrit.cloudera.org:8080/13807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e452a547973778bbd8d768c608e1a32e948f947 Gerrit-Change-Number: 13807 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 05 Jul 2019 14:09:49 +0000 Gerrit-HasComments: Yes
