Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13818 )
Change subject: IMPALA-8748: Always pass hostname to RpcMgr::GetProxy() ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13818/1/be/src/rpc/rpc-mgr.h File be/src/rpc/rpc-mgr.h: http://gerrit.cloudera.org:8080/#/c/13818/1/be/src/rpc/rpc-mgr.h@148 PS1, Line 148: has to match if Kerberos is enabled http://gerrit.cloudera.org:8080/#/c/13818/1/be/src/rpc/rpc-mgr.h@149 PS1, Line 149: which usually is not a resolved IP address The "usually" here seems to suggest that the DCHECK could fail in some cases? -- To view, visit http://gerrit.cloudera.org:8080/13818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85b661c8c3b3b67bfc1ce9e29aecb90a862666c0 Gerrit-Change-Number: 13818 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 09 Jul 2019 03:37:26 +0000 Gerrit-HasComments: Yes
