Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13774 )
Change subject: Support SPNEGO for Impala webserver ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13774/1/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/13774/1/be/src/util/webserver.cc@370 PS1, Line 370: LAGS_webserver_require_spnego) { > I don't think the --principal is actually necessary My point was that InitKerberosForServer() won't have actually been called unless --principal is set (see authentication.cc). Maybe my confusion is the word "assume" and it would be clearer to me if this was phrased as "checking" whether all of the necessary set up has been done? Unless we want to support a configuration where the webserver is secured with Kerberos but regular client connections aren't (which seems weird) > I think people will get pretty grouchy Works for me. Of course, we'll probably want to update the docs around Impala/Kerberos to mention this stuff -- To view, visit http://gerrit.cloudera.org:8080/13774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife2b04310e1571d231bf8ee1bcfd3b7afc2edd8f Gerrit-Change-Number: 13774 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 10 Jul 2019 17:43:43 +0000 Gerrit-HasComments: Yes
