Jiawei Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13801 )
Change subject: IMPALA-5149: Provide query profile in JSON format ...................................................................... Patch Set 6: (1 comment) Thanks for your feedback! I also added some tests for this. http://gerrit.cloudera.org:8080/#/c/13801/2/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/13801/2/be/src/service/impala-hs2-server.cc@979 PS2, Line 979: SQLSTATE_GENERAL_ERROR); : if (request.format == TRuntimeProfileFormat::THRIFT) { : return_val.__set_thrift_profile(thrift_profile); : } else if (request.format == TRuntimeProfileFormat::JSON) { : rapidjson::StringBuffer sb; : rapidjson::PrettyWriter<rapidjson::StringBuffer> writer(sb); : > should there be an equivalent here for JSON? Done. I am putting the output inside the profile, which is a string. Also, do we need to adopt this change to impala-beeswax-server? I looked at the code there but find that the function there only support text format download. -- To view, visit http://gerrit.cloudera.org:8080/13801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8181ac818bf22207ca1deabd9220c397ae723ec1 Gerrit-Change-Number: 13801 Gerrit-PatchSet: 6 Gerrit-Owner: Jiawei Wang <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jiawei Wang <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Thu, 11 Jul 2019 00:05:20 +0000 Gerrit-HasComments: Yes
