Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13845 )

Change subject: IMPALA-8681: Fix null pointer exception in  ValidWriteIdLists 
generation
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

Carry +2

http://gerrit.cloudera.org:8080/#/c/13845/1/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java
File fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java:

http://gerrit.cloudera.org:8080/#/c/13845/1/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java@61
PS1, Line 61: loadedOrFailedTbls_
> nit: maybe requestedTbls_?
I like the current name better even if it is long and ugly. :)



--
To view, visit http://gerrit.cloudera.org:8080/13845
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9d1dcf9b7496c4a80e9af82cadad8682085d849
Gerrit-Change-Number: 13845
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Yongzhi Chen <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Thu, 11 Jul 2019 18:54:06 +0000
Gerrit-HasComments: Yes

Reply via email to