radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 )
Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution ...................................................................... Patch Set 15: (3 comments) Updated the review with metric code, including actual metric collection on the frontend, metric "translation" on the backend, and the JNI plumbing to connect the 2. Only thing missing is the actual polling mechanism to make the connection... currently looking at other examples (e.g. event metrics) for some guidance. Commit `360b23bfa4eeb337cce380512f106a692bf3c49b` seems to be a good starting point(?) http://gerrit.cloudera.org:8080/#/c/13748/15/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/13748/15/be/src/service/impala-server.cc@75 PS15, Line 75: #include "util/hook-metrics.h" This will be used once I determine the best way to poll for metrics from the frontend http://gerrit.cloudera.org:8080/#/c/13748/15/be/src/util/hook-metrics-test.cc File be/src/util/hook-metrics-test.cc: http://gerrit.cloudera.org:8080/#/c/13748/15/be/src/util/hook-metrics-test.cc@23 PS15, Line 23: TEST(HookMetricContainer, UpdateTest) { Review is still WIP: I haven't actually ran this test yet, and I need to add more coverage for backend handling of metrics. http://gerrit.cloudera.org:8080/#/c/13748/15/be/src/util/hook-metrics.h File be/src/util/hook-metrics.h: http://gerrit.cloudera.org:8080/#/c/13748/15/be/src/util/hook-metrics.h@65 PS15, Line 65: TGetQueryEventHookMetricsResult* response); Review is still WIP because I need to actually call this function with metrics from the frontend. The JNI calls already exist, but I need some feedback on how to poll the frontend periodically for those metrics. -- To view, visit http://gerrit.cloudera.org:8080/13748 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb88422f7cfe86947d11ce57d2b4c63e57d1b643 Gerrit-Change-Number: 13748 Gerrit-PatchSet: 15 Gerrit-Owner: radford nguyen <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: radford nguyen <[email protected]> Gerrit-Comment-Date: Mon, 15 Jul 2019 12:45:45 +0000 Gerrit-HasComments: Yes
