Impala Public Jenkins has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/13804 )
Change subject: IMPALA-5031: Out-of-range enums are undefined behavior
......................................................................
IMPALA-5031: Out-of-range enums are undefined behavior
This eliminates an out-of-range enum value in the end-to-end
tests. The interesting part of the backtrace is:
exec/parquet/parquet-column-readers.cc:1530:112: runtime error: load
of value 38, which is not a valid value for type 'Encoding::type'
#0 BaseScalarColumnReader::ReadDataPage()
exec/parquet/parquet-column-readers.cc:1530:112
#1 BaseScalarColumnReader::NextPage()
exec/parquet/parquet-column-readers.cc:1769:28
#2 bool ScalarColumnReader<long, (parquet::Type::type)2, true>
::ReadValueBatch<false>(int, int, unsigned char*, int*)
exec/parquet/parquet-column-readers.cc:459:12
#3 ScalarColumnReader<long, (parquet::Type::type)2, true>
::ReadNonRepeatedValueBatch(MemPool*, int, int, unsigned char*,
int*) exec/parquet/parquet-column-readers.cc:106:12
#4 HdfsParquetScanner::AssembleRows(vector<ParquetColumnReader*>
const&, RowBatch*, bool*)
exec/parquet/hdfs-parquet-scanner.cc:1113:42
#5 HdfsParquetScanner::GetNextInternal(RowBatch*)
exec/parquet/hdfs-parquet-scanner.cc:456:19
#6 HdfsParquetScanner::ProcessSplit()
exec/parquet/hdfs-parquet-scanner.cc:353:21
#7 HdfsScanNode::ProcessSplit(vector<FilterContext> const&,
MemPool*, io::ScanRange*, long*) exec/hdfs-scan-node.cc:514:21
#8 HdfsScanNode::ScannerThread(bool, long)
exec/hdfs-scan-node.cc:415:7
#9 HdfsScanNode::ThreadTokenAvailableCb(ThreadResourcePool*)::$_0
::operator()() const exec/hdfs-scan-node.cc:337:13
Change-Id: Ia86de44daaf56a941fb95b15d5dfd7b5a2752129
Reviewed-on: http://gerrit.cloudera.org:8080/13804
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
---
M be/src/exec/parquet/parquet-column-readers.cc
M be/src/exec/parquet/parquet-level-decoder.cc
M be/src/exec/parquet/parquet-level-decoder.h
M common/thrift/parquet.thrift
4 files changed, 21 insertions(+), 6 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia86de44daaf56a941fb95b15d5dfd7b5a2752129
Gerrit-Change-Number: 13804
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Apple <jbap...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
