Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13809 )
Change subject: IMPALA-8710: Increase allowed bit width to 64 for bit packing ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/13809/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13809/4//COMMIT_MSG@9 PS4, Line 9: Fixed the buffer overflow that the previous attempt (commit > Instead of the change-id I think it's better to link the commit hash or may I added both. http://gerrit.cloudera.org:8080/#/c/13809/5/be/src/util/bit-packing.inline.h File be/src/util/bit-packing.inline.h: http://gerrit.cloudera.org:8080/#/c/13809/5/be/src/util/bit-packing.inline.h@196 PS5, Line 196: constexpr bool READ_32_BITS = WORDS_TO_READ == 1 > Can we safely read 32 bits when it is not a full batch? We can because BitPacking::UnpackUpTo31Values, which calls this function, DCHECKs the length of the input buffer. -- To view, visit http://gerrit.cloudera.org:8080/13809 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9276ca291e3d36db16f63f8caf3e9248a18d85b Gerrit-Change-Number: 13809 Gerrit-PatchSet: 6 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 17 Jul 2019 13:18:25 +0000 Gerrit-HasComments: Yes
