Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13873 )
Change subject: IMPALA-8656: Re-factor PlanRootSink into blocking and buffered implementations ...................................................................... IMPALA-8656: Re-factor PlanRootSink into blocking and buffered implementations Refactors PlanRootSink into a base class with two subclasses: BlockingPlanRootSink and BufferedPlanRootSink. BlockingPlanRootSink encapsulates the current implementation of PlanRootSink and BufferedPlanRootSink encapsulates a new implementation that will buffer RowBatches in memory until they are read by the client. The implementation of BlockingPlanRootSink is left to future work. A new query option called POOL_QUERY_RESULTS controls whether a BlockingPlanRootSink or a BufferedPlanRootSink is used as the DataSink. POOL_QUERY_RESULTS is false by default. Added a few more docs to PlanRootSink and BlockingPlanRootSink to make the implementation easier to understand. Testing: * Added tests/query_test/test_result_spooling.py; currently only runs a simple select limit 10 with SPOOL_QUERY_RESULTS = true and validates that 0 rows are returned * Ran core tests Change-Id: I8786b1a9af68ab0a8a094970d8f955eb20d04bca Reviewed-on: http://gerrit.cloudera.org:8080/13873 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exec/CMakeLists.txt A be/src/exec/blocking-plan-root-sink.cc A be/src/exec/blocking-plan-root-sink.h A be/src/exec/buffered-plan-root-sink.cc A be/src/exec/buffered-plan-root-sink.h M be/src/exec/data-sink.cc M be/src/exec/plan-root-sink.cc M be/src/exec/plan-root-sink.h M be/src/service/query-options.cc M be/src/service/query-options.h M common/thrift/ImpalaInternalService.thrift M common/thrift/ImpalaService.thrift A tests/query_test/test_result_spooling.py 13 files changed, 408 insertions(+), 154 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13873 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8786b1a9af68ab0a8a094970d8f955eb20d04bca Gerrit-Change-Number: 13873 Gerrit-PatchSet: 9 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
