Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13882 )
Change subject: IMPALA-7984: Port UpdateFilter() and PublishFilter() to KRPC ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/13882/2/be/src/runtime/runtime-filter-bank.cc File be/src/runtime/runtime-filter-bank.cc: http://gerrit.cloudera.org:8080/#/c/13882/2/be/src/runtime/runtime-filter-bank.cc@224 PS2, Line 224: params->min_max_filter(), it->second->type(), &obj_pool_, filter_mem_tracker_.get()); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/13882/2/be/src/util/min-max-filter.cc File be/src/util/min-max-filter.cc: http://gerrit.cloudera.org:8080/#/c/13882/2/be/src/util/min-max-filter.cc@378 PS2, Line 378: if (in_min_val < out_min_val) out->mutable_min()->set_timestamp_val(in.min().timestamp_val()); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/13882/2/be/src/util/min-max-filter.cc@381 PS2, Line 381: if (in_max_val > out_max_val) out->mutable_max()->set_timestamp_val(in.max().timestamp_val()); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/13882/2/be/src/util/min-max-filter.cc@404 PS2, Line 404: : size_(ColumnType::GetDecimalByteSize(precision)), always_false_(protobuf.always_false()) { line too long (94 > 90) -- To view, visit http://gerrit.cloudera.org:8080/13882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b394796d250286510e157ae326882bfc01d387a Gerrit-Change-Number: 13882 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Fri, 19 Jul 2019 06:28:24 +0000 Gerrit-HasComments: Yes
