Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13883 )
Change subject: IMPALA-8656: Add RowBatchQueue interface and BufferedPlanRootSink impl ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/13883/1/be/src/exec/buffered-plan-root-sink.cc File be/src/exec/buffered-plan-root-sink.cc: http://gerrit.cloudera.org:8080/#/c/13883/1/be/src/exec/buffered-plan-root-sink.cc@31 PS1, Line 31: // Close should only be called by the producer thread, no RowBatches should be sent after line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/13883/1/be/src/exec/buffered-plan-root-sink.cc@92 PS1, Line 92: // If the query was cancelled while the sink was waiting for rows to become available, or if line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/13883/1/be/src/exec/buffered-plan-root-sink.cc@94 PS1, Line 94: // The queue could be empty if the sink was closed while waiting for rows to become available, line too long (96 > 90) -- To view, visit http://gerrit.cloudera.org:8080/13883 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b1bb4b9c6f6e92c70e8fbee6ccdf48c2f85b7be Gerrit-Change-Number: 13883 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 19 Jul 2019 07:42:42 +0000 Gerrit-HasComments: Yes
