Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13515 )
Change subject: IMPALA-8176: Convert simple backend tests to the unified executable ...................................................................... Patch Set 6: (14 comments) http://gerrit.cloudera.org:8080/#/c/13515/2/be/src/codegen/CMakeLists.txt File be/src/codegen/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/13515/2/be/src/codegen/CMakeLists.txt@115 PS2, Line 115: unified be > Change to "unified be tests" Done http://gerrit.cloudera.org:8080/#/c/13515/2/be/src/exec/CMakeLists.txt File be/src/exec/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/13515/2/be/src/exec/CMakeLists.txt@120 PS2, Line 120: # Exception to unified be tests: Cust > Add exception description Done http://gerrit.cloudera.org:8080/#/c/13515/2/be/src/exprs/CMakeLists.txt File be/src/exprs/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/13515/2/be/src/exprs/CMakeLists.txt@77 PS2, Line 77: > Either convert or add exception Added http://gerrit.cloudera.org:8080/#/c/13515/2/be/src/exprs/CMakeLists.txt@79 PS2, Line 79: unified be > Change to "unified be tests" Done http://gerrit.cloudera.org:8080/#/c/13515/2/be/src/rpc/CMakeLists.txt File be/src/rpc/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/13515/2/be/src/rpc/CMakeLists.txt@49 PS2, Line 49: unified be Changed to "unified be tests" http://gerrit.cloudera.org:8080/#/c/13515/2/be/src/rpc/CMakeLists.txt@58 PS2, Line 58: ADD_BE_TEST(rpc-mgr-test) # TODO: this test leaks various KRP > remove Done http://gerrit.cloudera.org:8080/#/c/13515/2/be/src/runtime/CMakeLists.txt File be/src/runtime/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/13515/2/be/src/runtime/CMakeLists.txt@108 PS2, Line 108: unified be > "unified be tests" Done http://gerrit.cloudera.org:8080/#/c/13515/2/be/src/runtime/CMakeLists.txt@121 PS2, Line 121: unified be > "unified be tests" Done http://gerrit.cloudera.org:8080/#/c/13515/2/be/src/runtime/CMakeLists.txt@126 PS2, Line 126: # Exception to unified be tests: Custom main function with global Frontend object : ADD_BE_LSAN_TEST(row-batch-test) > Add exceptions Done http://gerrit.cloudera.org:8080/#/c/13515/2/be/src/runtime/CMakeLists.txt@128 PS2, Line 128: unified be > "unified be tests" Done http://gerrit.cloudera.org:8080/#/c/13515/2/be/src/runtime/bufferpool/CMakeLists.txt File be/src/runtime/bufferpool/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/13515/2/be/src/runtime/bufferpool/CMakeLists.txt@40 PS2, Line 40: unified be > "unified be tests" Done http://gerrit.cloudera.org:8080/#/c/13515/2/be/src/runtime/bufferpool/CMakeLists.txt@45 PS2, Line 45: unified be > "unified be tests" Done http://gerrit.cloudera.org:8080/#/c/13515/2/be/src/scheduling/CMakeLists.txt File be/src/scheduling/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/13515/2/be/src/scheduling/CMakeLists.txt@34 PS2, Line 34: scheduler-test-util.cc > Move to SchedulingTests Breaks scheduler-benchmark, so can't happen without more changes. http://gerrit.cloudera.org:8080/#/c/13515/2/be/src/service/CMakeLists.txt File be/src/service/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/13515/2/be/src/service/CMakeLists.txt@112 PS2, Line 112: unified be > "unified be tests" Done -- To view, visit http://gerrit.cloudera.org:8080/13515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I840d0f9b70edb3a7195a2a33b21fd2874d4c52bd Gerrit-Change-Number: 13515 Gerrit-PatchSet: 6 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 19 Jul 2019 17:51:55 +0000 Gerrit-HasComments: Yes
