Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13894 )
Change subject: modified MetaStoreEventsProcessor to catch multiple invalid configuration keys in one go. ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/13894/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/13894/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@242 PS1, Line 242: * Test if the error messages are caught appropriately when multiple config keys are invalid. line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/13894/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@247 PS1, Line 247: String actual_errorMessages="[Unexpected configuration value for hive.metastore.notifications.add.thrift.objects"+ line too long (118 > 90) http://gerrit.cloudera.org:8080/#/c/13894/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@248 PS1, Line 248: " in Hive Metastore. Expected: true Found: false, Unexpected configuration value for hive.metastore.dml"+ line too long (117 > 90) http://gerrit.cloudera.org:8080/#/c/13894/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@252 PS1, Line 252: List<MetastoreEventProcessorConfig> configKeys = new ArrayList<MetastoreEventProcessorConfig>() { line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/13894/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@259 PS1, Line 259: Mockito.when(test.getConfigValueFromMetastore(config.getValidator().getConfigKey(), "")). line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/13894/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@262 PS1, Line 262: for (MetastoreEventProcessorConfig config : test.getEventProcessorConfigsToValidate()) { line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/13894 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6f4b22a810714c7f2a3c35b7010781a8a071493 Gerrit-Change-Number: 13894 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 23 Jul 2019 17:02:10 +0000 Gerrit-HasComments: Yes
