Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13883 )
Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue interface and BufferedPRS impl ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13883/3/be/src/runtime/non-blocking-row-batch-queue.h File be/src/runtime/non-blocking-row-batch-queue.h: http://gerrit.cloudera.org:8080/#/c/13883/3/be/src/runtime/non-blocking-row-batch-queue.h@32 PS3, Line 32: NonBlockingRowBatchQueue > Yes, I agree the clean up of the RowBatchQueue interface is a good thing an Adding support for TryAddBatch and TryGetBatch to BlockingQueue isn't exactly trivial because it's using two internal std::deques (one for writing and one for reading). So I'm not sure if its worth the effort unless we have a long term use case? It's also more overhead to create a full BlockingQueue if we just end up just using the non-blocking APIs. The KrpcDataStreamRecvr::SenderQueue, for example, probably can't use any of the blocking APIs in BlockingQueue because it uses a lock to protect a bunch of member variables (since BlockingQueue BlockingGet/Put potentially waits on internal condition variables). What about just using std::queue inside BufferedPlanRootSink for now, and deferring the rest to a later patch when we add the BufferedTupleStream integration? I will still cleanup RowBatchQueue, but BufferedPlanRootSink won't use it for now. Thoughts? -- To view, visit http://gerrit.cloudera.org:8080/13883 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b1bb4b9c6f6e92c70e8fbee6ccdf48c2f85b7be Gerrit-Change-Number: 13883 Gerrit-PatchSet: 3 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 23 Jul 2019 22:04:07 +0000 Gerrit-HasComments: Yes
