Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13807 )
Change subject: IMPALA-8741: Speed up bit unpacking by vectorisation ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/13807/15/be/src/benchmarks/bit-packing-benchmark.cc File be/src/benchmarks/bit-packing-benchmark.cc: http://gerrit.cloudera.org:8080/#/c/13807/15/be/src/benchmarks/bit-packing-benchmark.cc@744 PS15, Line 744: : Is this intentional? http://gerrit.cloudera.org:8080/#/c/13807/4/be/src/util/bit-packing-vectorized.h File be/src/util/bit-packing-vectorized.h: PS4: > That is ok by me Yes, I prefer committing the generated file in this case. I can imagine a situation where having the generated file in github can save someone a few minutes of working, e.g. in case of stacktrace pointing there. I am not afraid of bit rot in this case, as the generator is very self contained. Unrelated: I would prefer to add "generated" or something similar to the file's name. http://gerrit.cloudera.org:8080/#/c/13807/15/be/src/util/bit-packing.h File be/src/util/bit-packing.h: http://gerrit.cloudera.org:8080/#/c/13807/15/be/src/util/bit-packing.h@63 PS15, Line 63: ue, nit: "the" not needed -- To view, visit http://gerrit.cloudera.org:8080/13807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e452a547973778bbd8d768c608e1a32e948f947 Gerrit-Change-Number: 13807 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 24 Jul 2019 13:59:27 +0000 Gerrit-HasComments: Yes
