Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13900 )
Change subject: IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for Parquet page indexes ...................................................................... Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_read_page_index.xml File docs/topics/impala_parquet_read_page_index.xml: http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_read_page_index.xml@61 PS2, Line 61: Float Float is not supported until PARQUET-1222 is not resolved. http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_read_page_index.xml@75 PS2, Line 75: Read statistics from Parquet pages and use : them in query processing. Read the page-level statistics from the Parquet page index during query processing and filter out pages based on that. http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_read_page_index.xml@80 PS2, Line 80: Do not use Parquet read page statistics. Do not use the Parquet page index. http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_write_page_index.xml File docs/topics/impala_parquet_write_page_index.xml: http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_write_page_index.xml@49 PS2, Line 49: This option enables the same optimization as the <codeph>PARQUET_READ_STATISTICS</codeph> : for writing at the finer grained page level. This paragraph doesn't really belong here since here we are talking about writing the stats. http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_write_page_index.xml@59 PS2, Line 59: Float Float is not supported until PARQUET-1222 is not resolved. http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_write_page_index.xml@63 PS2, Line 63: For simple predicates of the forms: <codeph><slot> <op> <constant></codeph> or : <codeph><constant> <op> <slot></codeph>, where <codeph><op></codeph> is LT, : LE, GE, GT, and EQ This doesn't really belong here. http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_write_page_index.xml@73 PS2, Line 73: Read Writes page-level statistics. http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_write_page_index.xml@78 PS2, Line 78: Do not use Parquet write page statistics. Do not write the Parquet page index. -- To view, visit http://gerrit.cloudera.org:8080/13900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46c1941269feff18306863f784aa36f5037da1db Gerrit-Change-Number: 13900 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 24 Jul 2019 16:28:02 +0000 Gerrit-HasComments: Yes
