Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13559 )
Change subject: IMPALA-8636: Implement INSERT for insert-only ACID tables ...................................................................... Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/13559/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13559/11//COMMIT_MSG@34 PS11, Line 34: > It's a good idea. I'm planning to add such tests in the following PS. Until I added some failure tests with debug actions. http://gerrit.cloudera.org:8080/#/c/13559/10/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/13559/10/be/src/service/client-request-state.cc@720 PS10, Line 720: UpdateEndTime(); > Thanks for the suggestion, moved it to FinalizeHdfsDml() We have quite a lot RETURN_IF_ERRORs, so I added the abort here again as a finalization if something went wrong. -- To view, visit http://gerrit.cloudera.org:8080/13559 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6c36fa6902676f06b4e38730f737becfc7c06ad Gerrit-Change-Number: 13559 Gerrit-PatchSet: 14 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 25 Jul 2019 10:55:33 +0000 Gerrit-HasComments: Yes
