Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/13898 )
Change subject: Patch Avro to 1.7.4-p5 to add DATE type support. ...................................................................... Patch Set 1: > I think we should really look at upstreaming this (and potentially > upgrading Avro to a more recent release), just so that we're not > maintaining a customer patchset. It would also be good to get > someone who knows avro better to review this - the code looks sane > but I'm not really qualified to review it. Impala uses the Avro C library which doesn't support logical types yet. This patch is a quick-and-dirty fix to add DATE type without a proper logical type implementation (we did the same thing for DECIMAL type). I doubt that the upstream Avro community would accept this patch without considerably more work. Alternatively we could switch to using the Avro C++ library which implements logical types (starting with 1.9.0 release). Integrating the new library into Impala would take some effort and may also introduce new issues. -- To view, visit http://gerrit.cloudera.org:8080/13898 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70aae9f16805e3ee806c39e9121b6525d83845b3 Gerrit-Change-Number: 13898 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 25 Jul 2019 15:34:02 +0000 Gerrit-HasComments: No
