Jim Apple has uploaded this change for review. (
http://gerrit.cloudera.org:8080/13940
Change subject: IMPALA-5031: widen Thrift enum to placate UBSAN
......................................................................
IMPALA-5031: widen Thrift enum to placate UBSAN
This fixes an instance of undefined behavior in the end-to-end tests
in which an enum value is outside of the allowable values for that
enum according to the C++14 standard.
Representative backtrace:
exec/parquet/parquet-metadata-utils.cc:293:26: runtime error: load of
value 49, which is not a valid value for type 'Type::type'
#0 ParquetMetadataUtils::ValidateRowGroupColumn(
parquet::FileMetaData const&, char const*, int, int,
parquet::SchemaElement const&, RuntimeState*)
exec/parquet/parquet-metadata-utils.cc:293:26
#1 BaseScalarColumnReader::Reset(HdfsFileDesc const&,
parquet::ColumnChunk const&, int)
exec/parquet/parquet-column-readers.cc:1077:43
#2 HdfsParquetScanner::InitScalarColumns()
exec/parquet/hdfs-parquet-scanner.cc:1679:60
#3 HdfsParquetScanner::NextRowGroup()
exec/parquet/hdfs-parquet-scanner.cc:648:45
#4 HdfsParquetScanner::GetNextInternal(RowBatch*)
exec/parquet/hdfs-parquet-scanner.cc:437:45
#5 HdfsParquetScanner::ProcessSplit()
exec/parquet/hdfs-parquet-scanner.cc:353:21
#6 HdfsScanNode::ProcessSplit(vector<FilterContext> const&,
MemPool*, io::ScanRange*, long*) exec/hdfs-scan-node.cc:514:21
#7 HdfsScanNode::ScannerThread(bool, long)
exec/hdfs-scan-node.cc:415:7
#8 HdfsScanNode::ThreadTokenAvailableCb(ThreadResourcePool*)::
$_0::operator()() const exec/hdfs-scan-node.cc:337:13
Change-Id: I48090e8e0c6c6f18bb1ad3c32c1f5fbffc908844
---
M common/thrift/parquet.thrift
1 file changed, 22 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/13940/1
--
To view, visit http://gerrit.cloudera.org:8080/13940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I48090e8e0c6c6f18bb1ad3c32c1f5fbffc908844
Gerrit-Change-Number: 13940
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <[email protected]>
