Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13947 )
Change subject: IMPALA-7975 : Improve supportability of the automatic invalidate feature ...................................................................... Patch Set 1: (1 comment) Congratulations on your first contribution. I left a comment below. http://gerrit.cloudera.org:8080/#/c/13947/1/be/src/util/event-metrics.h File be/src/util/event-metrics.h: http://gerrit.cloudera.org:8080/#/c/13947/1/be/src/util/event-metrics.h@59 PS1, Line 59: IntGauge Is there a reason why we want to use "guage" instead of a "counter"? IIUC, "guage" can increase or decrease over time whereas "counter" can only increase. Is there a case for LAST_SYNCED_EVENT_ID to decrease? -- To view, visit http://gerrit.cloudera.org:8080/13947 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib113a5b9458dcf483b183e927544a6c6d46e1af3 Gerrit-Change-Number: 13947 Gerrit-PatchSet: 1 Gerrit-Owner: Sharanitha Harish <sharanitha.har...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Tue, 30 Jul 2019 06:37:27 +0000 Gerrit-HasComments: Yes
