Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13968 )
Change subject: WIP IMPALA-8637: Implement transaction handling and locking for ACID queries ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13968/2/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/13968/2/fe/src/main/java/org/apache/impala/service/Frontend.java@1683 PS2, Line 1683: Do we have commitTransaction calls somewhere that actively call the transactionKeepalive_.deleteTransaction(txnId); method(instead of using keepalive to detect and remove)? http://gerrit.cloudera.org:8080/#/c/13968/2/fe/src/main/java/org/apache/impala/service/Frontend.java@1726 PS2, Line 1726: lockComponent.setType(LockType.EXCLUSIVE); Does hive have code to handle deadlock prevention? -- To view, visit http://gerrit.cloudera.org:8080/13968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa37899b24aa114be642bf8772b4e0f882865cfa Gerrit-Change-Number: 13968 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 01 Aug 2019 22:42:04 +0000 Gerrit-HasComments: Yes
