Vihang Karajgaonkar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14005 )

Change subject: Bump CDP_BUILD_NUMBER to 1318335
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14005/2/tests/custom_cluster/test_kudu.py
File tests/custom_cluster/test_kudu.py:

http://gerrit.cloudera.org:8080/#/c/14005/2/tests/custom_cluster/test_kudu.py@150
PS2, Line 150: kudu_hms_notifications_not_supported
Is there a KUDU jira for this?


http://gerrit.cloudera.org:8080/#/c/14005/2/tests/query_test/test_insert.py
File tests/query_test/test_insert.py:

http://gerrit.cloudera.org:8080/#/c/14005/2/tests/query_test/test_insert.py@151
PS2, Line 151: capability_check = 
self.hive_client.getMetaConf(CAPABILITY_CHECK_CONF)
             :     self.hive_client.setMetaConf(CAPABILITY_CHECK_CONF, "false")
             :     self.run_test_case('QueryTest/acid-insert', vector,
             :         
multiple_impalad=vector.get_value('exec_option')['sync_ddl'] == 1)
             :     # Reset original state.
             :     self.hive_client.setMetaConf(CAPABILITY_CHECK_CONF, 
capability_check)
Do we know why we HMS throws an error? May be the right way is to set the 
capabilities when we initialize the python Hive client.

Also, does the logic to check for capability needs to be in try .. finally 
block?



--
To view, visit http://gerrit.cloudera.org:8080/14005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I432e8c02dbd349a3507bfabfef2727914537652c
Gerrit-Change-Number: 14005
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Comment-Date: Mon, 05 Aug 2019 16:56:01 +0000
Gerrit-HasComments: Yes

Reply via email to