Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14008 )
Change subject: IMPALA-8832: Fix HTTP client protocol to work with Apache Knox ...................................................................... Patch Set 1: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/14008/1/be/src/rpc/auth-provider.h File be/src/rpc/auth-provider.h: http://gerrit.cloudera.org:8080/#/c/14008/1/be/src/rpc/auth-provider.h@63 PS1, Line 63: geenrated typo: generated http://gerrit.cloudera.org:8080/#/c/14008/1/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/14008/1/be/src/rpc/authentication.cc@1029 PS1, Line 1029: NULL nit:nullptr http://gerrit.cloudera.org:8080/#/c/14008/1/be/src/rpc/authentication.cc@1098 PS1, Line 1098: NULL nit: nullptr http://gerrit.cloudera.org:8080/#/c/14008/1/be/src/transport/THttpTransport.cpp File be/src/transport/THttpTransport.cpp: http://gerrit.cloudera.org:8080/#/c/14008/1/be/src/transport/THttpTransport.cpp@81 PS1, Line 81: readHeaders_ = true; It looks like upstream thrift still has these issues - worth filing a bug against them? https://github.com/apache/thrift/blob/master/lib/cpp/src/thrift/transport/THttpTransport.cpp -- To view, visit http://gerrit.cloudera.org:8080/14008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c9d934a654a9e6aaf9207fa5856f956baaacf55 Gerrit-Change-Number: 14008 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 05 Aug 2019 21:32:49 +0000 Gerrit-HasComments: Yes
