Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13967 )
Change subject: IMPALA-8816: reduce custom cluster test runtime in core ...................................................................... Patch Set 6: (2 comments) This looks good to me, a couple nits. http://gerrit.cloudera.org:8080/#/c/13967/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13967/6//COMMIT_MSG@24 PS6, Line 24: Speed up cluster starts by ensuring that the default statestore args are : applied even when _start_impala_cluster() is called directly. This : shaves a couple of seconds off each restart. Can you add a few words giving some context about why the default args speed up the time it takes for the cluster to be usable? e.g. mention that the default statestore args enable fast topic updates or reference IMPALA-7185 or something. http://gerrit.cloudera.org:8080/#/c/13967/6/tests/common/impala_service.py File tests/common/impala_service.py: http://gerrit.cloudera.org:8080/#/c/13967/6/tests/common/impala_service.py@256 PS6, Line 256: cannot : throw and exception can throw an exception -- To view, visit http://gerrit.cloudera.org:8080/13967 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2e3e7ebc9695baec4d69183387259958df10f62 Gerrit-Change-Number: 13967 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 06 Aug 2019 17:08:02 +0000 Gerrit-HasComments: Yes
