Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13807 )
Change subject: IMPALA-8741: Speed up bit unpacking by vectorisation ...................................................................... Patch Set 23: We found that the improvement in UnpackValues doesn't help much with dictionary and delta decoding, because dict decoding uses UnpackAndDecodeValues, which decodes the value right after unpacking as opposed to first unpacking all values and then decoding them. Delta is also faster this way. Therefore it is uncertain if introducing vectorisation is worth the added complexity now. On the other hand, restricting the unpacking output types to unsigned integers is independent from vectorisation and is a good idea, so I'll create a separate issue for it. -- To view, visit http://gerrit.cloudera.org:8080/13807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e452a547973778bbd8d768c608e1a32e948f947 Gerrit-Change-Number: 13807 Gerrit-PatchSet: 23 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 07 Aug 2019 15:58:22 +0000 Gerrit-HasComments: No
