Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 )
Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala ...................................................................... Patch Set 4: (5 comments) Hi Alex, thank you for the doc update. Added some minor comments. http://gerrit.cloudera.org:8080/#/c/14021/4/docs/topics/impala_default_transactional_type.xml File docs/topics/impala_default_transactional_type.xml: http://gerrit.cloudera.org:8080/#/c/14021/4/docs/topics/impala_default_transactional_type.xml@42 PS4, Line 42: The query option applies only when integrated with Hive : 3. nit: This could be in the pre-requisite note/important field. (please see my comment on line 60-68) http://gerrit.cloudera.org:8080/#/c/14021/4/docs/topics/impala_default_transactional_type.xml@50 PS4, Line 50: The default table type is not transactional. nit: this is a bit ambiguous, would be more clear something like: Default value, the created table will not be transactional. http://gerrit.cloudera.org:8080/#/c/14021/4/docs/topics/impala_default_transactional_type.xml@54 PS4, Line 54: The default table type is the insert-only transactional : table. nit: would be more clear something like: The created table will be marked as transactional, INSERT queries will be transactional on this table. http://gerrit.cloudera.org:8080/#/c/14021/4/docs/topics/impala_default_transactional_type.xml@60 PS4, Line 60: <p> : If either table properties, <codeph>transactional</codeph> or : <codeph>transactional_properties</codeph>, are set, this query option is ignored. : </p> : : <p> : The <codeph>DEFAULT_TRANSACTION_TYPE</codeph> query option does not affect external, Kudu, : or HBase tables as these cannot be transactional. : </p> nit: These could be in a note or important block, so users are warned about the prerequisites and scope of the query option. http://gerrit.cloudera.org:8080/#/c/14021/4/docs/topics/impala_transactions.xml File docs/topics/impala_transactions.xml: http://gerrit.cloudera.org:8080/#/c/14021/4/docs/topics/impala_transactions.xml@59 PS4, Line 59: Impala does not support changing transactional properties of tables. For example, you : cannot alter a transactional table to a non-transactional table. nit: this could be in a note/important as well -- To view, visit http://gerrit.cloudera.org:8080/14021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0320e573301175dedb00d6e745f9f973519a16bb Gerrit-Change-Number: 14021 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 07 Aug 2019 16:00:16 +0000 Gerrit-HasComments: Yes
