Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14040
to look at the new patch set (#2).
Change subject: IMPALA-8850: is_percent not initialized in TmpFileMgr parser
......................................................................
IMPALA-8850: is_percent not initialized in TmpFileMgr parser
This bug was only detected on ASAN. The is_percent variable
was not initialised and is not set in ParseMemSpec() when it
does an early exit for an empty string. This caused
TmpFileMgr to consider the empty memory spec after the colon
to be invalid.
Testing:
This reliably reproduced in TmpFileMgrTest under ASAN.
Initialising is_percent fixed the issue.
Added more detailed tests for ParseMemSpec() that initialise
is_percent to avoid similar bugs.
Change-Id: I4465944c7043c1fc6b33db9693ec290c24e3ed19
---
M be/src/util/parse-util-test.cc
M be/src/util/parse-util.cc
2 files changed, 22 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/14040/2
--
To view, visit http://gerrit.cloudera.org:8080/14040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4465944c7043c1fc6b33db9693ec290c24e3ed19
Gerrit-Change-Number: 14040
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
