Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14037 )
Change subject: IMPALA-8839: Remove COLUMN_STATS_ACCURATE from properties ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Besides the build fix for Hive 2 builds looks good to me. http://gerrit.cloudera.org:8080/#/c/14037/3/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/14037/3/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@110 PS3, Line 110: : /** > Done This signature should be changed in the Hive2 MetastoreShim too (this lead to compilation error in precommit build) http://gerrit.cloudera.org:8080/#/c/14037/3/tests/query_test/test_acid.py File tests/query_test/test_acid.py: http://gerrit.cloudera.org:8080/#/c/14037/3/tests/query_test/test_acid.py@104 PS3, Line 104: pIfABFS.hive > I have to use hive to create tables to make the test work for I need hive t This sounds weird, it would be good to investigate the cause, but I am ok with leaving it as it is for this patch. It is a known thing that without SYNC_DDL, other Impala coordinators may not see the new tables for some time, but it is surprising with Hive - Impala CREATE TABLE should wait for the table to be written to Metastore, and Hive queries always check the metastore for fresh data as far as I know. -- To view, visit http://gerrit.cloudera.org:8080/14037 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13f4a77022a7112e10a07314359f927eae083deb Gerrit-Change-Number: 14037 Gerrit-PatchSet: 4 Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Comment-Date: Sat, 10 Aug 2019 14:46:49 +0000 Gerrit-HasComments: Yes
