Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14012 )
Change subject: IMPALA-4551: Limit the size of SQL statements ...................................................................... Patch Set 2: (6 comments) LGTM. Just leave some "nit" comments. http://gerrit.cloudera.org:8080/#/c/14012/2/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/14012/2/be/src/service/query-options.h@190 PS2, Line 190: nit: Do we need spaces here according our code style? http://gerrit.cloudera.org:8080/#/c/14012/2/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/14012/2/be/src/service/query-options.cc@824 PS2, Line 824: Invalid statement expression limit nit: can we also print the value? http://gerrit.cloudera.org:8080/#/c/14012/2/be/src/service/query-options.cc@825 PS2, Line 825: Value typo: Valid http://gerrit.cloudera.org:8080/#/c/14012/2/be/src/service/query-options.cc@838 PS2, Line 838: value nit: values http://gerrit.cloudera.org:8080/#/c/14012/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/14012/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2861 PS2, Line 2861: String errorStr = String.format("Exceeded the statement expression limit (%s)\n" + nit: use "%d" for int. Looks like we use "%s" for INTs in many places. Are there any reasons? http://gerrit.cloudera.org:8080/#/c/14012/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java: http://gerrit.cloudera.org:8080/#/c/14012/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java@2443 PS2, Line 2443: // WHERE clause nit: For coverage, maybe test the expression in the WHERE clause? -- To view, visit http://gerrit.cloudera.org:8080/14012 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5675fb4a08c1dc51ae5bcf467cbb969cc064602c Gerrit-Change-Number: 14012 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 12 Aug 2019 03:00:56 +0000 Gerrit-HasComments: Yes
