Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14026 )
Change subject: IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/14026/3/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/14026/3/be/src/scheduling/scheduler.cc@796 PS3, Line 796: P((1/3)^(n-1)) Is there a typo here ? Not sure what (P(1/3^(n-1)) means ? http://gerrit.cloudera.org:8080/#/c/14026/3/be/src/scheduling/scheduler.cc@802 PS3, Line 802: 8 It seems clearer if we define this constant as a constant variable. http://gerrit.cloudera.org:8080/#/c/14026/3/be/src/scheduling/scheduler.cc@811 PS3, Line 811: if (candidates_it == remote_executor_candidates->end()) { > This is now O(n^2), right? Is there a bound on num_executors and if so, sho Or we can consider using an unordered_set to track the candidates found so far. My understanding is that order matters so we still need to return them in a vector, right ? -- To view, visit http://gerrit.cloudera.org:8080/14026 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfdb2cc53d7206e316ea8a1cc28ad443f246f741 Gerrit-Change-Number: 14026 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Comment-Date: Mon, 12 Aug 2019 21:09:05 +0000 Gerrit-HasComments: Yes
