Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14049 )
Change subject: IMPALA-8847: Ignore add partition events with empty partition list ...................................................................... Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/14049/3/tests/custom_cluster/test_event_processing.py File tests/custom_cluster/test_event_processing.py: http://gerrit.cloudera.org:8080/#/c/14049/3/tests/custom_cluster/test_event_processing.py@181 PS3, Line 181: def wait_for_insert_event_processing(self, previous_event_id): > I like that you moved out EventProcessorUtils. However, this file heavily u yes, I agree. I am planning to clean it up as part of IMPALA-8795. This method had some custom logic in place where it was waiting for 2 events so didn't want to touch that to keep the scope minimum. http://gerrit.cloudera.org:8080/#/c/14049/3/tests/custom_cluster/test_event_processing.py@200 PS3, Line 200: get_event_processor_metrics > Same as my above comment, this function can be removed here and modify this I am planning to clean up all the event polling tests together in IMPALA-8795 http://gerrit.cloudera.org:8080/#/c/14049/3/tests/custom_cluster/test_event_processing.py@215 PS3, Line 215: get_last_synced_event_id > Same as previous comment. I am planning to clean up all the event polling tests together in IMPALA-8795 http://gerrit.cloudera.org:8080/#/c/14049/3/tests/util/event_processor_utils.py File tests/util/event_processor_utils.py: http://gerrit.cloudera.org:8080/#/c/14049/3/tests/util/event_processor_utils.py@27 PS3, Line 27: class EventProcessorUtils(object): > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/14049/3/tests/util/event_processor_utils.py@30 PS3, Line 30: D > flake8: E303 too many blank lines (2) Done http://gerrit.cloudera.org:8080/#/c/14049/3/tests/util/event_processor_utils.py@50 PS3, Line 50: . > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/14049/3/tests/util/event_processor_utils.py@56 PS3, Line 56: @ > flake8: E303 too many blank lines (2) Done -- To view, visit http://gerrit.cloudera.org:8080/14049 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I877ce6233934e7090cd18e497f748bc6479838cb Gerrit-Change-Number: 14049 Gerrit-PatchSet: 3 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Mon, 12 Aug 2019 21:55:44 +0000 Gerrit-HasComments: Yes
