Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14043 )

Change subject: IMPALA-8842 part 1: Accommodate HIVE-22046 - Step 2.
......................................................................


Patch Set 4: Code-Review+1

(3 comments)

http://gerrit.cloudera.org:8080/#/c/14043/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14043/4//COMMIT_MSG@7
PS4, Line 7: IMPALA-8842 part 1: Accommodate HIVE-22046 - Step 2
nit: I would prefer something more descriptive like "(Hive3) Use 'engine' field 
in HMS stat API"


http://gerrit.cloudera.org:8080/#/c/14043/4//COMMIT_MSG@7
PS4, Line 7: part 1
What does part 1 mean? Will there be additional changes after part 1 step 4?


http://gerrit.cloudera.org:8080/#/c/14043/4//COMMIT_MSG@40
PS4, Line 40:
About testing: there were EE tests in 
https://gerrit.cloudera.org/#/c/14032/4/tests/metadata/test_hms_integration.py

Shouldn't that work at this point? Please add a comment if the tests do not 
work yet or add the tests if they do.



--
To view, visit http://gerrit.cloudera.org:8080/14043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a73f5eeac8e84d63b22aaed5dfbcd8ea39f0af4
Gerrit-Change-Number: 14043
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Jeges <atti...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Aug 2019 13:12:45 +0000
Gerrit-HasComments: Yes

Reply via email to